linux-kernel - [tip: irq/core] genirq: Set IRQF_COND_ONESHOT in request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172073187601.2215.10067243809116446863.tip-bot2@tip-bot2>
Date: Thu, 11 Jul 2024 21:04:36 -0000
From: "tip-bot2 for Rafael J. Wysocki" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Stefan Seyfried <stefan.seyfried@...glemail.com>,
 "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
 Thomas Gleixner <tglx@...utronix.de>, stable@...r.kerel.org, x86@...nel.org,
 linux-kernel@...r.kernel.org, maz@...nel.org
Subject: [tip: irq/core] genirq: Set IRQF_COND_ONESHOT in request_irq()

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     513fbe762f644872cc2ff47407cbc24422a33fb5
Gitweb:        https://git.kernel.org/tip/513fbe762f644872cc2ff47407cbc24422a33fb5
Author:        Rafael J. Wysocki <rafael.j.wysocki@...el.com>
AuthorDate:    Thu, 11 Jul 2024 12:20:04 +02:00
Committer:     Thomas Gleixner <tglx@...utronix.de>
CommitterDate: Thu, 11 Jul 2024 22:59:33 +02:00

genirq: Set IRQF_COND_ONESHOT in request_irq()

The callers of request_irq() don't care about IRQF_ONESHOT because they
don't provide threaded handlers, but if they happen to share the IRQ with
the ACPI SCI, which has a threaded handler and sets IRQF_ONESHOT,
request_irq() will fail for them due to a flags mismatch.

Address this by making request_irq() add IRQF_COND_ONESHOT to the flags
passed to request_threaded_irq() for all of its callers.

Fixes: 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler for SCI")
Reported-by: Stefan Seyfried <stefan.seyfried@...glemail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Tested-by: Stefan Seyfried <stefan.seyfried@...glemail.com>
Cc: stable@...r.kerel.org
Link: https://lore.kernel.org/r/5800834.DvuYhMxLoT@rjwysocki.net
Closes: https://lore.kernel.org/lkml/205bd84a-fe8e-4963-968e-0763285f35ba@message-id.googlemail.com
---
 include/linux/interrupt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 5c9bdd3..dac7466 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -168,7 +168,7 @@ static inline int __must_check
 request_irq(unsigned int irq, irq_handler_t handler, unsigned long flags,
 	    const char *name, void *dev)
 {
-	return request_threaded_irq(irq, handler, NULL, flags, name, dev);
+	return request_threaded_irq(irq, handler, NULL, flags | IRQF_COND_ONESHOT, name, dev);
 }

 extern int __must_check