[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1a686673-9ffa-4574-a095-923d0e168893@baylibre.com>
Date: Thu, 11 Jul 2024 16:36:40 -0500
From: David Lechner <dlechner@...libre.com>
To: Kim Seer Paller <kimseer.paller@...log.com>,
linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org
Cc: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen
<lars@...afoo.de>, Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>, Dimitri Fedrau <dima.fedrau@...il.com>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Michael Hennerich <michael.hennerich@...log.com>,
Nuno Sá <noname.nuno@...il.com>
Subject: Re: [PATCH v6 3/6] dt-bindings: iio: dac: Generalize DAC common
properties
On 7/11/24 6:42 AM, Kim Seer Paller wrote:
> Introduce a generalized DAC binding that can be used by DACs that have
> similar properties adding output-range-microamp and output-range-microvolt.
>
> Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> ---
> .../devicetree/bindings/iio/dac/dac.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/dac.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/dac.yaml b/Documentation/devicetree/bindings/iio/dac/dac.yaml
> new file mode 100644
> index 000000000000..a9787bbcd22b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/dac.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/dac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IIO Common Properties for DAC Channels
> +
> +maintainers:
> + - Jonathan Cameron <jic23@...nel.org>
> +
> +description:
> + A few properties are defined in a common way for DAC channels.
> +
> +properties:
> + $nodename:
> + pattern: "^channel(@[0-9a-f]+)?$"
> + description:
> + A channel index should match reg.
> +
> + reg:
> + maxItems: 1
> +
> + label:
> + description: Unique name to identify which channel this is.
> +
> + output-range-microamp:
> + maxItems: 2
> + minItems: 2
> + description:
> + Specify the channel output full scale range in microamperes.
> +
> + output-range-microvolt:
> + maxItems: 2
> + minItems: 2
> + description:
> + Specify the channel output full scale range in microvolts.
> +
> +oneOf:
> + - required:
> + - reg
> + - output-range-microamp
> + - required:
> + - reg
> + - output-range-microvolt
> +
> +required:
> + - reg
> +
It looks like oneOf: and required: are missing an indent, which is
likely the cause of the Rob-bot complaints.
Also, shouldn't the last required: be an item in the oneOf: list?
> +additionalProperties: true
Powered by blists - more mailing lists