linux-kernel - Re: [PATCH v2] bootconfig: Remove duplicate included header file linux/bootconfig.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240712083548.374a6c4ff925251cd74db051@kernel.org>
Date: Fri, 12 Jul 2024 08:35:48 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v2] bootconfig: Remove duplicate included header file
 linux/bootconfig.h

On Thu, 11 Jul 2024 10:43:16 +0200
Thorsten Blum <thorsten.blum@...lux.com> wrote:

> The header file linux/bootconfig.h is included whether __KERNEL__ is
> defined or not.
> 
> Include it only once before the #ifdef/#else/#endif preprocessor
> directives and remove the following make includecheck warning:
> 
>   linux/bootconfig.h is included more than once
> 
> Move the comment to the top and delete the now empty #else block.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>

Thanks, looks good to me. Let me pick it up.

> ---
> Changes in v2:
> - Move comment and delete #else as suggested by Masami Hiramatsu
> - Link to v1: https://lore.kernel.org/linux-kernel/20240711002152.800028-2-thorsten.blum@toblux.com/
> ---
>  lib/bootconfig.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/lib/bootconfig.c b/lib/bootconfig.c
> index 97f8911ea339..81f29c29f47b 100644
> --- a/lib/bootconfig.c
> +++ b/lib/bootconfig.c
> @@ -4,8 +4,16 @@
>   * Masami Hiramatsu <mhiramat@...nel.org>
>   */
>  
> -#ifdef __KERNEL__
> +/*
> + * NOTE: This is only for tools/bootconfig, because tools/bootconfig will
> + * run the parser sanity test.
> + * This does NOT mean lib/bootconfig.c is available in the user space.
> + * However, if you change this file, please make sure the tools/bootconfig
> + * has no issue on building and running.
> + */
>  #include <linux/bootconfig.h>
> +
> +#ifdef __KERNEL__
>  #include <linux/bug.h>
>  #include <linux/ctype.h>
>  #include <linux/errno.h>
> @@ -24,16 +32,6 @@ const char * __init xbc_get_embedded_bootconfig(size_t *size)
>  	return (*size) ? embedded_bootconfig_data : NULL;
>  }
>  #endif
> -
> -#else /* !__KERNEL__ */
> -/*
> - * NOTE: This is only for tools/bootconfig, because tools/bootconfig will
> - * run the parser sanity test.
> - * This does NOT mean lib/bootconfig.c is available in the user space.
> - * However, if you change this file, please make sure the tools/bootconfig
> - * has no issue on building and running.
> - */
> -#include <linux/bootconfig.h>
>  #endif
>  
>  /*
> -- 
> 2.39.2
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>