linux-kernel - Re: [PATCH 0/3] ARM: Use generic interface to simplify crashkernel reservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb647b6d-55cb-4fa2-6e2f-642d10afa719@huawei.com>
Date: Thu, 11 Jul 2024 14:30:11 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Baoquan He <bhe@...hat.com>
CC: <linux@...linux.org.uk>, <vgoyal@...hat.com>, <dyoung@...hat.com>,
	<paul.walmsley@...ive.com>, <palmer@...belt.com>, <aou@...s.berkeley.edu>,
	<arnd@...db.de>, <afd@...com>, <akpm@...ux-foundation.org>,
	<rmk+kernel@...linux.org.uk>, <linus.walleij@...aro.org>,
	<eric.devolder@...cle.com>, <gregkh@...uxfoundation.org>, <deller@....de>,
	<javierm@...hat.com>, <robh@...nel.org>, <thunder.leizhen@...wei.com>,
	<austindh.kim@...il.com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <kexec@...ts.infradead.org>
Subject: Re: [PATCH 0/3] ARM: Use generic interface to simplify crashkernel
 reservation



On 2024/7/9 17:29, Baoquan He wrote:
> On 07/08/24 at 09:33pm, Jinjie Ruan wrote:
>> Currently, x86, arm64, riscv and loongarch has been switched to generic
>> crashkernel reservation. Also use generic interface to simplify crashkernel
>> reservation for arm32, and fix two bugs by the way.
> 
> I am not sure if this is a good idea. I added the generic reservation
> itnerfaces for ARCH which support crashkernel=,high|low and normal
> crashkernel reservation, with this, the code can be simplified a lot.
> However, arm32 doesn't support crashkernel=,high, I am not sure if it's
> worth taking the change, most importantly, if it will cause
> misunderstanding or misoperation.

It seems that x86_32 doesn't support crashkernel=,high and use the
generic interface，and also have the first patch bug. I’ll resend the
first patch and explain it.

> 
> Thanks
> Baoquan
> 
>