linux-kernel - Re: [PATCH] hid: usbhid: Enable remote wake-up based on device configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024071104-rental-bleak-b273@gregkh>
Date: Thu, 11 Jul 2024 09:41:45 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Alan Stern <stern@...land.harvard.edu>, ryan <ryanzhou54@...il.com>,
	jikos@...nel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: usbhid: Enable remote wake-up based on device
 configuration

On Wed, Jul 10, 2024 at 09:47:39PM -0400, Alan Stern wrote:
> On Thu, Jul 11, 2024 at 07:16:06AM +0800, ryan wrote:
> > According to the USB protocol, the host should automatically
> > adapt the remote wake-up function based on the configuration
> > descriptor reported by the device, rather than only the default
> > keyboard support. Therefore, it's necessary to support other hid
> > devices, such as digital headsets,mice,etc.
> 
> It's true that the host shouldn't try to enable remote wakeup if the 
> configuration descriptor shows that the device doesn't support it.
> 
> However, it's not true that the host should try to enable remote wakeup 
> for devices other than keyboards with boot-protocol support.  History 
> has shown that quite a few HID devices don't handle remote wakeup 
> properly; the decision about whether to enable it should be left to the 
> user.

I agree, this patch isn't acceptable.  Ryan, why do you want this
applied?  What userspace control is missing to allow you to do this
today on your systems with no kernel changes for devices that you know
will work properly?

thanks,

greg k-h