linux-kernel - Re: [PATCH] drivers/clocksource/qcom: Add missing iounmap() on error when reading clock frequency.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <069282eb-d891-4537-bdc0-85de17b5e61f@linaro.org>
Date: Thu, 11 Jul 2024 10:13:38 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Ankit Agrawal <agrawal.ag.ankit@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/clocksource/qcom: Add missing iounmap() on error
 when reading clock frequency.

On 11.07.2024 10:11 AM, Konrad Dybcio wrote:
> On 11.07.2024 7:49 AM, Ankit Agrawal wrote:
>> On Wed, Jul 10, 2024 at 01:54:01PM +0200, Konrad Dybcio wrote:
>>> On 10.07.2024 1:08 PM, Ankit Agrawal wrote:

[...]

> 
> Ohh right source_base is a global variable.. perhaps the original patch
> here makes more sense given we definitely don't wanna unmap that..
> 
> So I'd say let's go with this one after all
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

We should probably also check if msm_timer_init() succeeds and unmap
if that fails.. we can just check the return value of that function
and if it's non-zero, call iounmap

Konrad