linux-kernel - Re: [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172068668209.928451.13962575882186553669.robh@kernel.org>
Date: Thu, 11 Jul 2024 02:31:22 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: conor+dt@...nel.org, krzk+dt@...nel.org, quic_kriskura@...cinc.com, 
 linux-kernel@...r.kernel.org, johan+linaro@...nel.org, andersson@...nel.org, 
 linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org, 
 konrad.dybcio@...aro.org, gregkh@...uxfoundation.org, 
 devicetree@...r.kernel.org, quic_wcheng@...cinc.com
Subject: Re: [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for
 interrupt info


On Thu, 11 Jul 2024 12:26:14 +0530, Varadarajan Narayanan wrote:
> IPQ5332 has only three interrupts. Update min items
> accordingly for interrupt names to fix the following
> dt_binding_check errors.
> 
> 	interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
> 
> Fixes: a5c7592366af ("dt-bindings: usb: qcom,dwc3: add SC8280XP binding")
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml: allOf:12:then:properties:interrupt-names: {'minItems': 3, 'maxItems': 4, 'items': [{'const': 'pwr_event'}, {'const': 'dp_hs_phy_irq'}, {'const': 'dm_hs_phy_irq'}, {'const': 'ss_phy_irq'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240711065615.2720367-1-quic_varada@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.