linux-kernel - Re: [PATCH v2 1/2] net: pse-pd: Do not return EOPNOSUPP if config is null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240711105326.1a5b6b0b@kmaincent-XPS-13-7390>
Date: Thu, 11 Jul 2024 10:53:26 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 thomas.petazzoni@...tlin.com, Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2 1/2] net: pse-pd: Do not return EOPNOSUPP if config
 is null

On Thu, 11 Jul 2024 09:43:00 +0100
Simon Horman <horms@...nel.org> wrote:

> On Wed, Jul 10, 2024 at 01:42:30PM +0200, Kory Maincent wrote:
> > For a PSE supporting both c33 and PoDL, setting config for one type of PoE
> > leaves the other type's config null. Currently, this case returns
> > EOPNOTSUPP, which is incorrect. Instead, we should do nothing if the
> > configuration is empty.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> > Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE
> > framework") ---
> > 
> > Changes in v2:
> > - New patch to fix dealing with a null config.  
> 
> Hi Kory,
> 
> A few thing from a process perspective:
> 
> 1. As fixes, with fixes tags (good!), this patchset seems like it is
>    appropriate for net rather than net-next. And indeed it applies
>    to net but not net-next. However, the absence of a target tree
>    confuses our CI which failed to apply the patchset to net-next.
> 
>    Probably this means it should be reposted, targeted at net.
> 
>    Subject: [Patch v3 net x/y] ...
> 
>    See: https://docs.kernel.org/process/maintainer-netdev.html

Oops indeed sorry, forgot to add the net prefix.

> 2. Please provide a cover letter for patch sets with more than one
>    (but not just one) patch. That provides an overview of how
>    the patches relate to each other. And a convenient anchor for
>    feedback such as point 1 above.
> 
> ...

As my first version contained only one patch I did not thought of adding a
cover letter for the 2nd version but indeed I should. Sorry.

Thanks for the reminder I will try to not have my head in the cloud next time.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com