[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a908a3fb-22f0-4ee5-9550-bc716debd4aa@kernel.org>
Date: Thu, 11 Jul 2024 11:03:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
quic_wcheng@...cinc.com, johan+linaro@...nel.org, quic_kriskura@...cinc.com,
linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for
interrupt info
On 11/07/2024 10:47, Varadarajan Narayanan wrote:
> On Thu, Jul 11, 2024 at 09:47:23AM +0200, Krzysztof Kozlowski wrote:
>> On 11/07/2024 08:56, Varadarajan Narayanan wrote:
>>> IPQ5332 has only three interrupts. Update min items
>>> accordingly for interrupt names to fix the following
>>> dt_binding_check errors.
>>>
>>> interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
>>>
>>> Fixes: a5c7592366af ("dt-bindings: usb: qcom,dwc3: add SC8280XP binding")
>>
>> There is no ipq5332 at this commit, so I do not understand which bug are
>> you fixing.
>
> a5c7592366af introduced this interrupt and interrupt-names block. Later, 53c6d854be4e9 added ipq5332 to this section. Since a5c7592366af introduced the maxItems and I wanted to include minItems also (to accomodate ipq5332) I used a5c7592366af in the fixes tag. Will 53c6d854be4e9 be a more appropriate choice?
At least a5c7592366af cannot be, because there is no bug in
a5c7592366af. Otherwise please explain what bug is present at time of
a5c7592366af?
Best regards,
Krzysztof
Powered by blists - more mailing lists