linux-kernel - Re: [PATCH 2/4] Bluetooth: hci_uart: Add support for Amlogic HCI UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f5bacb8-6361-4f4a-9c51-9ec4eb30d2e2@amlogic.com>
Date: Thu, 11 Jul 2024 18:33:11 +0800
From: Yang Li <yang.li@...ogic.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Catalin Marinas
 <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Ye He <ye.he@...ogic.com>
Subject: Re: [PATCH 2/4] Bluetooth: hci_uart: Add support for Amlogic HCI UART


On 2024/7/7 21:10, Krzysztof Kozlowski wrote:
> [Some people who received this message don't often get email from krzk@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
>
> On 05/07/2024 13:20, Yang Li via B4 Relay wrote:
>> From: Yang Li <yang.li@...ogic.com>
>>
>> This patch introduces support for Amlogic Bluetooth controller over
>> UART. In order to send the final firmware at full speed. It is a pretty
>> straight forward H4 driver with exception of actually having it's own
>> setup address configuration.
>>
>> Co-developed-by: Ye He <ye.he@...ogic.com>
> Read submitting patches. Missing SoB.
Will do.
>
>> Signed-off-by: Yang Li <yang.li@...ogic.com>
>> ---
>>   drivers/bluetooth/Kconfig     |  13 +
>
>
>> +
>> +static void aml_serdev_remove(struct serdev_device *serdev)
>> +{
>> +     struct aml_serdev *amldev = serdev_device_get_drvdata(serdev);
>> +
>> +     hci_uart_unregister_device(&amldev->serdev_hu);
>> +}
>> +
>> +static const struct aml_device_data data_w155s2 __maybe_unused = {
>> +     .iccm_offset = 256 * 1024,
>> +};
>> +
>> +static const struct aml_device_data data_w265s2 __maybe_unused = {
> How this can be "maybe_unused" while it is referenced always? This is
> buggy. Either everything in OF chain can be unused or not. Not half yes,
> half not.
well, i will remove __maybe_unused.
>
>> +     .iccm_offset = 384 * 1024,
>> +};
>> +
>> +static const struct of_device_id aml_bluetooth_of_match[] = {
>> +     { .compatible = "amlogic,w155s2-bt", .data = &data_w155s2 },
>> +     { .compatible = "amlogic,w265s2-bt", .data = &data_w265s2 },
>> +     { /* sentinel */ },
>> +};
>> +
>> +static struct serdev_device_driver aml_serdev_driver = {
>> +     .probe = aml_serdev_probe,
>> +     .remove = aml_serdev_remove,
>> +     .driver = {
>> +             .name = "hci_uart_aml",
>> +             .of_match_table = of_match_ptr(aml_bluetooth_of_match),
> So now you have warnings... drop of_match_ptr.
Will do.
>
> Best regards,
> Krzysztof
>