| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202407111957.xE3bLmJi-lkp@intel.com>
Date: Thu, 11 Jul 2024 19:53:26 +0800
From: kernel test robot <lkp@...el.com>
To: WANG Xuerui <git@...0n.name>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Huacai Chen <chenhuacai@...nel.org>
Subject: drivers/pci/controller/pcie-mediatek.c:925:43: warning: '%d'
directive output may be truncated writing between 1 and 10 bytes into a
region of size 6
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9d9a2f29aefdadc86e450308ff056017a209c755
commit: 3f301dc292eb122eff61b8b2906e519154b0327f LoongArch: Replace -ffreestanding with finer-grained -fno-builtin's
date: 11 months ago
config: loongarch-randconfig-001-20240711 (https://download.01.org/0day-ci/archive/20240711/202407111957.xE3bLmJi-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240711/202407111957.xE3bLmJi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407111957.xE3bLmJi-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/pci/controller/pcie-mediatek.c: In function 'mtk_pcie_parse_port':
>> drivers/pci/controller/pcie-mediatek.c:925:43: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 6 [-Wformat-truncation=]
925 | snprintf(name, sizeof(name), "port%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:925:38: note: directive argument in the range [0, 2147483647]
925 | snprintf(name, sizeof(name), "port%d", slot);
| ^~~~~~~~
drivers/pci/controller/pcie-mediatek.c:925:9: note: 'snprintf' output between 6 and 15 bytes into a destination of size 10
925 | snprintf(name, sizeof(name), "port%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:932:45: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
932 | snprintf(name, sizeof(name), "sys_ck%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:932:38: note: directive argument in the range [0, 2147483647]
932 | snprintf(name, sizeof(name), "sys_ck%d", slot);
| ^~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:932:9: note: 'snprintf' output between 8 and 17 bytes into a destination of size 10
932 | snprintf(name, sizeof(name), "sys_ck%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:940:45: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
940 | snprintf(name, sizeof(name), "ahb_ck%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:940:38: note: directive argument in the range [0, 2147483647]
940 | snprintf(name, sizeof(name), "ahb_ck%d", slot);
| ^~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:940:9: note: 'snprintf' output between 8 and 17 bytes into a destination of size 10
940 | snprintf(name, sizeof(name), "ahb_ck%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:945:45: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
945 | snprintf(name, sizeof(name), "axi_ck%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:945:38: note: directive argument in the range [0, 2147483647]
945 | snprintf(name, sizeof(name), "axi_ck%d", slot);
| ^~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:945:9: note: 'snprintf' output between 8 and 17 bytes into a destination of size 10
945 | snprintf(name, sizeof(name), "axi_ck%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:950:45: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
950 | snprintf(name, sizeof(name), "aux_ck%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:950:38: note: directive argument in the range [0, 2147483647]
950 | snprintf(name, sizeof(name), "aux_ck%d", slot);
| ^~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:950:9: note: 'snprintf' output between 8 and 17 bytes into a destination of size 10
950 | snprintf(name, sizeof(name), "aux_ck%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:955:46: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 3 [-Wformat-truncation=]
955 | snprintf(name, sizeof(name), "obff_ck%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:955:38: note: directive argument in the range [0, 2147483647]
955 | snprintf(name, sizeof(name), "obff_ck%d", slot);
| ^~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:955:9: note: 'snprintf' output between 9 and 18 bytes into a destination of size 10
955 | snprintf(name, sizeof(name), "obff_ck%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:960:46: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 3 [-Wformat-truncation=]
960 | snprintf(name, sizeof(name), "pipe_ck%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:960:38: note: directive argument in the range [0, 2147483647]
960 | snprintf(name, sizeof(name), "pipe_ck%d", slot);
| ^~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:960:9: note: 'snprintf' output between 9 and 18 bytes into a destination of size 10
960 | snprintf(name, sizeof(name), "pipe_ck%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:965:47: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]
965 | snprintf(name, sizeof(name), "pcie-rst%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:965:38: note: directive argument in the range [0, 2147483647]
965 | snprintf(name, sizeof(name), "pcie-rst%d", slot);
| ^~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:965:9: note: 'snprintf' output between 10 and 19 bytes into a destination of size 10
965 | snprintf(name, sizeof(name), "pcie-rst%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:971:47: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]
971 | snprintf(name, sizeof(name), "pcie-phy%d", slot);
| ^~
drivers/pci/controller/pcie-mediatek.c:971:38: note: directive argument in the range [0, 2147483647]
971 | snprintf(name, sizeof(name), "pcie-phy%d", slot);
| ^~~~~~~~~~~~
drivers/pci/controller/pcie-mediatek.c:971:9: note: 'snprintf' output between 10 and 19 bytes into a destination of size 10
971 | snprintf(name, sizeof(name), "pcie-phy%d", slot);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +925 drivers/pci/controller/pcie-mediatek.c
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 910
4f6f0460448d57 drivers/pci/host/pcie-mediatek.c Honghui Zhang 2017-08-10 911 static int mtk_pcie_parse_port(struct mtk_pcie *pcie,
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 912 struct device_node *node,
4f6f0460448d57 drivers/pci/host/pcie-mediatek.c Honghui Zhang 2017-08-10 913 int slot)
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 914 {
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 915 struct mtk_pcie_port *port;
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 916 struct device *dev = pcie->dev;
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 917 struct platform_device *pdev = to_platform_device(dev);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 918 char name[10];
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 919 int err;
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 920
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 921 port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 922 if (!port)
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 923 return -ENOMEM;
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 924
1eacd7b84e0413 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 @925 snprintf(name, sizeof(name), "port%d", slot);
e2dcd20b1645a7 drivers/pci/controller/pcie-mediatek.c Dejin Zheng 2020-06-03 926 port->base = devm_platform_ioremap_resource_byname(pdev, name);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 927 if (IS_ERR(port->base)) {
4f6f0460448d57 drivers/pci/host/pcie-mediatek.c Honghui Zhang 2017-08-10 928 dev_err(dev, "failed to map port%d base\n", slot);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 929 return PTR_ERR(port->base);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 930 }
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 931
4f6f0460448d57 drivers/pci/host/pcie-mediatek.c Honghui Zhang 2017-08-10 932 snprintf(name, sizeof(name), "sys_ck%d", slot);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 933 port->sys_ck = devm_clk_get(dev, name);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 934 if (IS_ERR(port->sys_ck)) {
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 935 dev_err(dev, "failed to get sys_ck%d clock\n", slot);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 936 return PTR_ERR(port->sys_ck);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 937 }
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 938
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 939 /* sys_ck might be divided into the following parts in some chips */
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 940 snprintf(name, sizeof(name), "ahb_ck%d", slot);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 941 port->ahb_ck = devm_clk_get_optional(dev, name);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 942 if (IS_ERR(port->ahb_ck))
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 943 return PTR_ERR(port->ahb_ck);
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 944
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 945 snprintf(name, sizeof(name), "axi_ck%d", slot);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 946 port->axi_ck = devm_clk_get_optional(dev, name);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 947 if (IS_ERR(port->axi_ck))
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 948 return PTR_ERR(port->axi_ck);
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 949
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 950 snprintf(name, sizeof(name), "aux_ck%d", slot);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 951 port->aux_ck = devm_clk_get_optional(dev, name);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 952 if (IS_ERR(port->aux_ck))
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 953 return PTR_ERR(port->aux_ck);
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 954
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 955 snprintf(name, sizeof(name), "obff_ck%d", slot);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 956 port->obff_ck = devm_clk_get_optional(dev, name);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 957 if (IS_ERR(port->obff_ck))
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 958 return PTR_ERR(port->obff_ck);
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 959
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 960 snprintf(name, sizeof(name), "pipe_ck%d", slot);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 961 port->pipe_ck = devm_clk_get_optional(dev, name);
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 962 if (IS_ERR(port->pipe_ck))
6be22343cc546b drivers/pci/controller/pcie-mediatek.c Chunfeng Yun 2019-04-10 963 return PTR_ERR(port->pipe_ck);
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 964
4f6f0460448d57 drivers/pci/host/pcie-mediatek.c Honghui Zhang 2017-08-10 965 snprintf(name, sizeof(name), "pcie-rst%d", slot);
608fcac7ce31b9 drivers/pci/host/pcie-mediatek.c Philipp Zabel 2017-07-19 966 port->reset = devm_reset_control_get_optional_exclusive(dev, name);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 967 if (PTR_ERR(port->reset) == -EPROBE_DEFER)
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 968 return PTR_ERR(port->reset);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 969
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 970 /* some platforms may use default PHY setting */
4f6f0460448d57 drivers/pci/host/pcie-mediatek.c Honghui Zhang 2017-08-10 971 snprintf(name, sizeof(name), "pcie-phy%d", slot);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 972 port->phy = devm_phy_optional_get(dev, name);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 973 if (IS_ERR(port->phy))
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 974 return PTR_ERR(port->phy);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 975
4f6f0460448d57 drivers/pci/host/pcie-mediatek.c Honghui Zhang 2017-08-10 976 port->slot = slot;
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 977 port->pcie = pcie;
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 978
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 979 if (pcie->soc->setup_irq) {
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 980 err = pcie->soc->setup_irq(port, node);
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 981 if (err)
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 982 return err;
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 983 }
b099631df160ec drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-08-10 984
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 985 INIT_LIST_HEAD(&port->list);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 986 list_add_tail(&port->list, &pcie->ports);
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 987
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 988 return 0;
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 989 }
637cfacae96fa6 drivers/pci/host/pcie-mediatek.c Ryder Lee 2017-05-21 990
:::::: The code at line 925 was first introduced by commit
:::::: 1eacd7b84e0413f55fbc0c61874f745cc5e2ed9e PCI: mediatek: Switch to use platform_get_resource_byname()
:::::: TO: Ryder Lee <ryder.lee@...iatek.com>
:::::: CC: Bjorn Helgaas <bhelgaas@...gle.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists