[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240711120707.GL4587@noisy.programming.kicks-ass.net>
Date: Thu, 11 Jul 2024 14:07:07 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Jiri Olsa <olsajiri@...il.com>
Cc: mingo@...nel.org, andrii@...nel.org, oleg@...hat.com,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
rostedt@...dmis.org, mhiramat@...nel.org, clm@...a.com,
paulmck@...nel.org
Subject: Re: [PATCH v2 01/11] perf/uprobe: Re-indent labels
On Thu, Jul 11, 2024 at 01:58:04PM +0200, Jiri Olsa wrote:
> On Thu, Jul 11, 2024 at 01:02:36PM +0200, Peter Zijlstra wrote:
>
> SNIP
>
> > @@ -1159,7 +1159,7 @@ static int __uprobe_register(struct inod
> > if (!IS_ALIGNED(ref_ctr_offset, sizeof(short)))
> > return -EINVAL;
> >
> > - retry:
> > +retry:
> > uprobe = alloc_uprobe(inode, offset, ref_ctr_offset);
> > if (!uprobe)
> > return -ENOMEM;
> > @@ -1468,7 +1468,7 @@ static int xol_add_vma(struct mm_struct
> > ret = 0;
> > /* pairs with get_xol_area() */
> > smp_store_release(&mm->uprobes_state.xol_area, area); /* ^^^ */
> > - fail:
> > +fail:
> > mmap_write_unlock(mm);
> >
> > return ret;
> > @@ -1512,7 +1512,7 @@ static struct xol_area *__create_xol_are
> > kfree(area->bitmap);
> > free_area:
>
> hi,
> missed this one and another one few lines before that ;-)
Bah, _ isn't in [[:alnum:]]. I'll go fix.
Powered by blists - more mailing lists