[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <96f14a07-0b82-45b4-8c72-edeb1e2e52af@linaro.org>
Date: Thu, 11 Jul 2024 13:19:21 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Kees Cook <kees@...nel.org>,
Stanimir Varbanov <stanimir.k.varbanov@...il.com>
Cc: Vikash Garodia <quic_vgarodia@...cinc.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>, linux-media@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-hardening@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: venus: hfi_cmds: struct
hfi_session_release_buffer_pkt: Replace 1-element array with flexible array
On 11/07/2024 00:09, Kees Cook wrote:
> Replace the deprecated[1] use of a 1-element array in
> struct hfi_session_release_buffer_pkt with a modern flexible array.
>
> No binary differences are present after this conversion.
>
> Link: https://github.com/KSPP/linux/issues/79 [1]
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Stanimir Varbanov <stanimir.k.varbanov@...il.com>
> Cc: Vikash Garodia <quic_vgarodia@...cinc.com>
> Cc: "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: linux-media@...r.kernel.org
> Cc: linux-arm-msm@...r.kernel.org
> Cc: linux-hardening@...r.kernel.org
> ---
> drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h
> index 20acd412ee7b..42825f07939d 100644
> --- a/drivers/media/platform/qcom/venus/hfi_cmds.h
> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h
> @@ -227,7 +227,7 @@ struct hfi_session_release_buffer_pkt {
> u32 extradata_size;
> u32 response_req;
> u32 num_buffers;
> - u32 buffer_info[1];
> + u32 buffer_info[];
> };
>
> struct hfi_session_release_resources_pkt {
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Powered by blists - more mailing lists