[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1458500b-150f-4882-992c-02823cb8dcf8@denx.de>
Date: Thu, 11 Jul 2024 13:47:02 +0200
From: Marek Vasut <marex@...x.de>
To: pieterjanca@...il.com, Pavel Machek <pavel@....cz>,
Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Isai Gaspar <isaiezequiel.gaspar@....com>
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] leds: leds-pca995x: Add support for NXP PCA9956B
On 7/11/24 9:52 AM, Pieterjan Camerlynck via B4 Relay wrote:
[...]
> @@ -52,9 +69,9 @@ struct pca995x_led {
> };
>
> struct pca995x_chip {
> + const struct pca995x_chipdef *chipdef;
> struct regmap *regmap;
> struct pca995x_led leds[PCA995X_MAX_OUTPUTS];
> - int btype;
Nitpick, maybe you can replace btype with chipdef in this place, without
reordering the structure ?
> };
>
> static int pca995x_brightness_set(struct led_classdev *led_cdev,
In any case:
Reviewed-by: Marek Vasut <marex@...x.de>
Thanks !
Powered by blists - more mailing lists