linux-kernel - Re: [PATCH v2 56/60] i2c: viai2c: reword according to newest specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6arkyo4dg3k2ya6oitgv4ajcd55ncf2xfgm4o76jfbkvn4wca6@7qf3kjaq5sci>
Date: Thu, 11 Jul 2024 15:05:24 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-i2c@...r.kernel.org, Hans Hu <hanshu@...oxin.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 56/60] i2c: viai2c: reword according to newest
 specification

Hi Wolfram,

> diff --git a/drivers/i2c/busses/i2c-viai2c-zhaoxin.c b/drivers/i2c/busses/i2c-viai2c-zhaoxin.c
> index ab3e44e147e9..95dc64902b7c 100644
> --- a/drivers/i2c/busses/i2c-viai2c-zhaoxin.c
> +++ b/drivers/i2c/busses/i2c-viai2c-zhaoxin.c
> @@ -38,7 +38,7 @@
>  #define ZXI2C_GOLD_FSTP_400K	0x38
>  #define ZXI2C_GOLD_FSTP_1M	0x13
>  #define ZXI2C_GOLD_FSTP_3400K	0x37
> -#define ZXI2C_HS_MASTER_CODE	(0x08 << 8)
> +#define ZXI2C_HS_CTRL_CODE	(0x08 << 8)

They also look like driver specific rather than hardware.

Hans, can you please confirm?

For the time being:

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Thanks,
Andi