[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0e9ddeba-ca2e-6f92-dde0-b74629928864@quicinc.com>
Date: Thu, 11 Jul 2024 19:03:34 +0530
From: Sibi Sankar <quic_sibis@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <sudeep.holla@....com>,
<cristian.marussi@....com>, <andersson@...nel.org>,
<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<quic_rgottimu@...cinc.com>, <quic_kshivnan@...cinc.com>,
<conor+dt@...nel.org>, Amir Vajid <avajid@...cinc.com>
Subject: Re: [RFC V3 2/4] firmware: arm_scmi: vendors: Add ARM SCMI QCOM
vendor protocol v1.0
On 7/9/24 15:40, Konrad Dybcio wrote:
> On 2.07.2024 9:14 PM, Sibi Sankar wrote:
>> The ARM SCMI QCOM vendor protocol provides a generic way of exposing a
>> number of Qualcomm SoC specific features (like memory bus scaling) through
>> a mixture of pre-determined algorithm strings and param_id pairs hosted on
>> the SCMI controller.
>>
>
> [...]
Hey Konrad,
Thanks for taking time to review the series.
>
>> +/**
>> + * qcom_scmi_vendor_protocol_cmd - vendor specific commands supported by Qualcomm SCMI
>> + * vendor protocol.
>
> include the word 'enum' or:
>
> warning: cannot understand function prototype: 'enum qcom_scmi_vendor_protocol_cmd '
will fix it in the next re-spin.
-Sibi
>
> Konrad
Powered by blists - more mailing lists