linux-kernel - Re: [RESEND PATCH] rtc: ds1343: Force SPI chip select to be active high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd7c0eb9-bcb6-42e3-8be6-3d07452e3fd5@sirena.org.uk>
Date: Thu, 11 Jul 2024 15:21:08 +0100
From: Mark Brown <broonie@...nel.org>
To: Ian Abbott <abbotti@....co.uk>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [RESEND PATCH] rtc: ds1343: Force SPI chip select to be active
 high

On Thu, Jul 11, 2024 at 03:05:01PM +0100, Ian Abbott wrote:

> I think the devicetree node for the RTC device ought to be setting
> `spi-cs-high` but cannot do so at the moment because the driver clobbers it.

Specifying spi-cs-high in the device tree should almost always be
redundant or a mistake, if the device needs a high chip select then we
already know that from the compatible.  The property is adding nothing
but potential confusion, in the normal course of affairs the driver
should just specify the configuration it needs for the bus.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)