| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240712001718.e00caa0a3cb410dc19f169c2@kernel.org> Date: Fri, 12 Jul 2024 00:17:18 +0900 From: Masami Hiramatsu (Google) <mhiramat@...nel.org> To: Peter Zijlstra <peterz@...radead.org> Cc: Andrii Nakryiko <andrii.nakryiko@...il.com>, Masami Hiramatsu <mhiramat@...nel.org>, Jiri Olsa <olsajiri@...il.com>, mingo@...nel.org, andrii@...nel.org, linux-kernel@...r.kernel.org, rostedt@...dmis.org, oleg@...hat.com, clm@...a.com, paulmck@...nel.org, bpf <bpf@...r.kernel.org> Subject: Re: [PATCH 00/10] perf/uprobe: Optimize uprobes On Thu, 11 Jul 2024 10:51:18 +0200 Peter Zijlstra <peterz@...radead.org> wrote: > On Wed, Jul 10, 2024 at 11:40:17AM -0700, Andrii Nakryiko wrote: > > On Wed, Jul 10, 2024 at 7:56 AM Masami Hiramatsu <mhiramat@...nel.org> wrote: > > > > > > On Wed, 10 Jul 2024 12:10:03 +0200 > > > Peter Zijlstra <peterz@...radead.org> wrote: > > > > > > > On Wed, Jul 10, 2024 at 07:10:46AM +0900, Masami Hiramatsu wrote: > > > > > > > > > > FFS :-/ That touches all sorts and doesn't have any perf ack on. Masami > > > > > > what gives? > > > > > > > > > > This is managing *probes and related dynamic trace-events. Those has been > > > > > moved from tip. Could you also add linux-trace-kernel@...r ML to CC? > > > > > > > > ./scripts/get_maintainer.pl -f kernel/events/uprobes.c > > > > > > > > disagrees with that, also things like: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/commit/?h=probes/for-next&id=4a365eb8a6d9940e838739935f1ce21f1ec8e33f > > > > > > > > touch common perf stuff, and very much would require at least an ack > > > > from the perf folks. > > > > > > Hmm, indeed. I'm OK to pass those patches (except for trace_uprobe things) > > > to -tip if you can. > > > > > > > > > > > Not cool. > > > > > > > You were aware of this patch and cc'ed personally (just like > > linux-perf-users@...r.kernel.org) on all revisions of it. I addressed > > your concerns in [0], you went silent after that and patches were > > sitting idle for more than a month. > > Yeah, I remember seeing it. But I was surprised it got applied. If I'm > tardy -- this can happen, more so of late since I'm still recovering > from injury and I get far more email than I could hope to process in a > work day -- please ping. I also forgot to ping you. I'll ask you next time. > > (also, being 'forced' into using a split keyboard means I'm also > re-learning how to type, further slowing me down -- training muscle > memory takes a while) > > Taking patches that touch other trees is fairly common, but in all those > cases an ACK is 'required'. OK, should I wait for your Ack for other patches on probes/for-next? > > (also also, I'm not the only maintainer there) > > > But regardless, if you'd like me to do any adjustments, please let me know. > > > > [0] https://lore.kernel.org/all/CAEf4Bzazi7YMz9n0V46BU7xthQjNdQL_zma5vzgCm_7C-_CvmQ@mail.gmail.com/ > > > > I'll check, it might be fine, its just the surprise of having it show up > in some random tree that set me off. > > > > Yeah, the probe things are boundary. > > > BTW, IMHO, there could be dependency issues on *probes. Those are usually used > > > by ftrace/perf/bpf, which are managed by different trees. This means a series > > > can span multiple trees. Mutually reviewing is the solution? > > > > > > > I agree, there is no one best tree for stuff like this. So as long as > > relevant people and mailing lists are CC'ed we hopefully should be > > fine? > > Typically, yeah, that should work just fine. > > But if Masami wants to do uprobes, then it might be prudent to add a > MAINTAINERS entry for it. > > A solution might be to add a UPROBES entry and add masami, oleg (if he > wants) and myself as maintainers -- did I forget anyone? Git seems to > suggest it's mostly been Oleg carrying this thing. That sounds good for me. Like this? >From 87dfb9c0e7660e83debd69a0c7e28bc61d214fa8 Mon Sep 17 00:00:00 2001 From: "Masami Hiramatsu (Google)" <mhiramat@...nel.org> Date: Fri, 12 Jul 2024 00:08:30 +0900 Subject: [PATCH] MAINTAINERS: Add uprobes entry Add uprobes entry to MAINTAINERS and move its maintenance on the linux-trace tree as same as other probes. Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org> --- MAINTAINERS | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index da5352dbd4f3..7f6285d98b39 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23105,6 +23105,18 @@ F: drivers/mtd/ubi/ F: include/linux/mtd/ubi.h F: include/uapi/mtd/ubi-user.h +UPROBES +M: Masami Hiramatsu <mhiramat@...nel.org> +M: Oleg Nesterov <oleg@...hat.com> +M: Peter Zijlstra <peterz@...radead.org> +L: linux-kernel@...r.kernel.org +L: linux-trace-kernel@...r.kernel.org +S: Maintained +Q: https://patchwork.kernel.org/project/linux-trace-kernel/list/ +T: git git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git +F: include/linux/uprobes.h +F: kernel/events/uprobes.c + USB "USBNET" DRIVER FRAMEWORK M: Oliver Neukum <oneukum@...e.com> L: netdev@...r.kernel.org -- 2.34.1 Thanks, -- Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists