linux-kernel - Re: [PATCH v2] bitmap: Switch from inline to __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202407121059.9FC2D0DF@keescook>
Date: Fri, 12 Jul 2024 11:01:13 -0700
From: Kees Cook <kees@...nel.org>
To: Yury Norov <yury.norov@...il.com>
Cc: Brian Norris <briannorris@...omium.org>,
	Nathan Chancellor <nathan@...nel.org>, llvm@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v2] bitmap: Switch from inline to __always_inline

On Fri, Jul 12, 2024 at 10:02:55AM -0700, Yury Norov wrote:
> Hi Brian,
> 
> Thanks for taking over this!
> 
> + Kees Cook for GCC
> [...]
> But I'm not sure about that and don't know how to check what happens
> under the compilers' hood. Can compiler gurus please clarify?

I don't know much about GCC internals. I just ask GCC devs nicely to
help us where they can. :)

> >   Subject: [PATCH 1/3] bitmap: switch from inline to __always_inline

We always expected them to be inline, and if we need to hit the
compilers harder with __always_inline, that seems sensible to me.

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook