linux-kernel - Re: [PATCH v7 9/9] iio: adc: ad7173: Add support for AD411x devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240712182311.GA1454666-robh@kernel.org>
Date: Fri, 12 Jul 2024 12:23:11 -0600
From: Rob Herring <robh@...nel.org>
To: Dumitru Ceclan <dumitru.ceclan@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	David Lechner <dlechner@...libre.com>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dumitru Ceclan <mitrutzceclan@...il.com>
Subject: Re: [PATCH v7 9/9] iio: adc: ad7173: Add support for AD411x devices

On Fri, Jun 07, 2024 at 05:53:15PM +0300, Dumitru Ceclan wrote:
> Add support for AD4111/AD4112/AD4114/AD4115/AD4116.
> 
> The AD411X family encompasses a series of low power, low noise, 24-bit,
> sigma-delta analog-to-digital converters that offer a versatile range of
> specifications.
> 
> This family of ADCs integrates an analog front end suitable for processing
> both fully differential and single-ended, bipolar voltage inputs
> addressing a wide array of industrial and instrumentation requirements.
> 
> - All ADCs have inputs with a precision voltage divider with a division
>   ratio of 10.
> - AD4116 has 5 low level inputs without a voltage divider.
> - AD4111 and AD4112 support current inputs (0 mA to 20 mA) using a 50ohm
>   shunt resistor.
> 
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
> ---

[...]

> @@ -1194,6 +1434,11 @@ static int ad7173_probe(struct spi_device *spi)
>  }
>  
>  static const struct of_device_id ad7173_of_match[] = {
> +	{ .compatible = "ad4111",	.data = &ad4111_device_info },
> +	{ .compatible = "ad4112",	.data = &ad4112_device_info },
> +	{ .compatible = "ad4114",	.data = &ad4114_device_info },
> +	{ .compatible = "ad4115",	.data = &ad4115_device_info },
> +	{ .compatible = "ad4116",	.data = &ad4116_device_info },

These are all missing the 'adi,' vendor prefix. Please fix.

>  	{ .compatible = "adi,ad7172-2", .data = &ad7172_2_device_info },
>  	{ .compatible = "adi,ad7172-4", .data = &ad7172_4_device_info },
>  	{ .compatible = "adi,ad7173-8", .data = &ad7173_8_device_info },