linux-kernel - Re: [net-next PATCH v9 05/11] octeontx2-af: Add packet path between representor and VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd40e1b9-cb76-4617-b699-19f1f580fe98@web.de>
Date: Fri, 12 Jul 2024 21:52:14 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Geetha sowjanya <gakula@...vell.com>, netdev@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Hariprasad Kelam <hkelam@...vell.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
 Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [net-next PATCH v9 05/11] octeontx2-af: Add packet path between
 representor and VF

> Current HW, do not support in-built switch which will forward pkts
…
              does?          built-in?

How do you think about to avoid any abbreviations for another improved change description?

…
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c
…
> +void rvu_rep_update_rules(struct rvu *rvu, u16 pcifunc, bool ena)
> +{
…
> +	rvu_switch_enable_lbk_link(rvu, pcifunc, ena);
> +	mutex_lock(&mcam->lock);
> +	for (entry = 0; entry < max; entry++) {
…
> +	}
> +	mutex_unlock(&mcam->lock);
> +}
…

Under which circumstances would you become interested to apply a construct
like “scoped_guard(mutex, &mcam->lock)”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/cleanup.h#L137

Regards,
Markus