linux-kernel - Re: [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZpGdDcuKNcX-Bcir@ryzen.lan>
Date: Fri, 12 Jul 2024 23:15:57 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Damien Le Moal <dlemoal@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" <linux-ide@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add
 fsl,ls1046a-ahci and fsl,ls1012a-ahci

On Fri, Jul 12, 2024 at 04:59:38PM -0400, Frank Li wrote:
> On Fri, Jul 12, 2024 at 10:52:39PM +0200, Niklas Cassel wrote:
> > On Fri, Jul 12, 2024 at 02:57:40PM -0400, Frank Li wrote:
> > > Add missing documented compatible strings 'fsl,ls1046a-ahci' and
> > > 'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to
> > > 'fsl,ls1043a-ahci'.
> > > 
> > > Fix below CHECK_DTB warnings
> > > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@...0000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci']
> > > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@...0000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long
> > 
> > These lines should have been wrapped to 75 lines IMO.
> > I will fixup when applying.
> 
> Thanks, according to my knowledge, computer generate warning, error, log...
> doesn't require wrap.

Yes, that is correct, especially for critical things like a kernel oops etc.

In this case, I don't think a simple CHECK_DTB warning is critical enough to
warrant keeping a line length of 232 columns, but I agree that 'critical
enough' is subjective.


Kind regards,
Niklas