linux-kernel - Re: [PATCH v2 1/5] cxl/hdm: Moving HDM specific code to core/hdm.c.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <669079864eb84_5fffa294b8@dwillia2-xfh.jf.intel.com.notmuch>
Date: Thu, 11 Jul 2024 17:32:06 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Robert Richter <rrichter@....com>, Alison Schofield
	<alison.schofield@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, "Ira
 Weiny" <ira.weiny@...el.com>, Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>, Dave Jiang
	<dave.jiang@...el.com>, Davidlohr Bueso <dave@...olabs.net>
CC: <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Robert
 Richter" <rrichter@....com>
Subject: Re: [PATCH v2 1/5] cxl/hdm: Moving HDM specific code to core/hdm.c.

Robert Richter wrote:
> Code to handle HDM specifics is implemented in core/pci.c and
> core/hdm.c. In both files helper functions will be needed for address
> translation. To simplify the introduction of static helper functions,
> move all HDM code to core/hdm.c.
> 
> The function devm_cxl_enable_mem() is no longer static and is shared
> now within the core module. No functional changes otherwise.

Looks ok.

Reviewed-by: Dan Williams <dan.j.williams@...el.com>