linux-kernel - Re: [PATCH v5 04/11] irqchip/mips-gic: Support multi-cluster in for_each_online_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202407121224.kUAil6pa-lkp@intel.com>
Date: Fri, 12 Jul 2024 12:38:07 +0800
From: kernel test robot <lkp@...el.com>
To: Aleksandar Rikalo <arikalo@...il.com>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: oe-kbuild-all@...ts.linux.dev,
	Aleksandar Rikalo <aleksandar.rikalo@...mia.com>,
	Chao-ying Fu <cfu@...ecomp.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Greg Ungerer <gerg@...nel.org>, Hauke Mehrtens <hauke@...ke-m.de>,
	Ilya Lipnitskiy <ilya.lipnitskiy@...il.com>,
	Jiaxun Yang <jiaxun.yang@...goat.com>, linux-kernel@...r.kernel.org,
	linux-mips@...r.kernel.org, Marc Zyngier <maz@...nel.org>,
	Paul Burton <paulburton@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Serge Semin <fancer.lancer@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tiezhu Yang <yangtiezhu@...ngson.cn>
Subject: Re: [PATCH v5 04/11] irqchip/mips-gic: Support multi-cluster in
 for_each_online_cpu_gic()

Hi Aleksandar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on tip/timers/core linus/master v6.10-rc7]
[cannot apply to daniel-lezcano/clockevents/next next-20240711]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aleksandar-Rikalo/MIPS-CPS-Add-a-couple-of-multi-cluster-utility-functions/20240711-164850
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20240711082656.1889440-5-arikalo%40gmail.com
patch subject: [PATCH v5 04/11] irqchip/mips-gic: Support multi-cluster in for_each_online_cpu_gic()
config: mips-allnoconfig (https://download.01.org/0day-ci/archive/20240712/202407121224.kUAil6pa-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240712/202407121224.kUAil6pa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407121224.kUAil6pa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/irqchip/irq-mips-gic.c:102: warning: expecting prototype for for_each_online_cpu_gic(). Prototype was for gic_unlock_cluster() instead


vim +102 drivers/irqchip/irq-mips-gic.c

    90	
    91	/**
    92	 * for_each_online_cpu_gic() - Iterate over online CPUs, access local registers
    93	 * @cpu: An integer variable to hold the current CPU number
    94	 * @gic_lock: A pointer to raw spin lock used as a guard
    95	 *
    96	 * Iterate over online CPUs & configure the other/redirect register region to
    97	 * access each CPUs GIC local register block, which can be accessed from the
    98	 * loop body using read_gic_vo_*() or write_gic_vo_*() accessor functions or
    99	 * their derivatives.
   100	 */
   101	static inline void gic_unlock_cluster(void)
 > 102	{
   103		if (mips_cps_multicluster_cpus())
   104			mips_cm_unlock_other();
   105	}
   106	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki