linux-kernel - Re: [PATCH v3 2/2] clk: samsung: gs101: don't mark non-essential (UART) clocks critical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74fd5d7cabfda98f578b5a4d4f4df1adba05ca3d.camel@linaro.org>
Date: Fri, 12 Jul 2024 06:00:19 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Marek Szyprowski <m.szyprowski@...sung.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Peter Griffin <peter.griffin@...aro.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>, Chanwoo Choi
 <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>, Michael
 Turquette <mturquette@...libre.com>,  Stephen Boyd <sboyd@...nel.org>, Sam
 Protsenko <semen.protsenko@...aro.org>, Tudor Ambarus
 <tudor.ambarus@...aro.org>
Cc: Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com, 
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v3 2/2] clk: samsung: gs101: don't mark non-essential
 (UART) clocks critical

On Wed, 2024-07-10 at 16:35 +0200, Marek Szyprowski wrote:
> I think that it would be much better to check if earlycon is specified 
> in kernel's cmdline and if so, simply mark those problematic clocks 
> critical in this driver. Make this code hidden under 
> IS_ENABLED(CONFIG_SERIAL_EARLYCON) to avoid polluting release builds. 
> Any comments?

Good idea, I've found that i.MX appears to suffer from a similar problem,
and I'm testing something similar now:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/imx/clk.c#n157


Cheers,
Andre'