linux-kernel - Re: [PATCH] iommu/vt-d: Fix identity map bounds in si_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMC_AXWbG_6DSOekjjoUnzPCR3UpS1P_p1AL7kLHO=AnVEhHtg@mail.gmail.com>
Date: Fri, 12 Jul 2024 00:05:48 -0700
From: Jon Pan-Doh <pandoh@...gle.com>
To: "Tian, Kevin" <kevin.tian@...el.com>
Cc: David Woodhouse <dwmw2@...radead.org>, Lu Baolu <baolu.lu@...ux.intel.com>, 
	Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>, 
	"H. Peter Anvin" <hpa@...ux.intel.com>, Tejun Heo <tj@...nel.org>, 
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sudheer Dantuluri <dantuluris@...gle.com>, 
	Gary Zibrat <gzibrat@...gle.com>
Subject: Re: [PATCH] iommu/vt-d: Fix identity map bounds in si_domain_init()

On Tue, Jul 9, 2024 at 5:49 PM Tian, Kevin <kevin.tian@...el.com> wrote:
> s/aas/as/

Ack.

> > Fixes: 5dfe8660a3d7 ("bootmem: Replace work_with_active_regions() with
> > for_each_mem_pfn_range()")
>
> this doesn't appear to be the original commit introducing this bug.
>
> Even the old work_with_active_regions() way used exclusive end_pfn
> while it's not adjusted when calling iommu_domain_identity_map().

Oops. I did not look far enough back. I believe the correct tag is

Fixes: c5395d5c4a82 ("intel-iommu: Clean up iommu_domain_identity_map()")

I'll send out a v2 once Baolu's comments are addressed.

Thanks,
Jon