linux-kernel - Re: linux-next: build failure after merge of the leds-lj tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240712082153.GP501857@google.com>
Date: Fri, 12 Jul 2024 09:21:53 +0100
From: Lee Jones <lee@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the leds-lj tree

On Fri, 12 Jul 2024, Christian Marangi wrote:

> On Fri, Jul 12, 2024 at 08:31:39AM +0100, Lee Jones wrote:
> > Christian,
> > 
> > > Hi all,
> > > 
> > > After merging the leds-lj tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > In file included from drivers/leds/leds-lp5569.c:11:
> > > drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
> > > drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
> > >   204 |                           chip, LP5569_REG_STATUS, &val);
> > >       |                                                    ^~~~
> > >       |                                                    |
> > >       |                                                    int *
> > 
> > The only reason for applying this set this late in the cycle was that
> > they appeared to be fixes for other brokenness.
> > 
> > This is the second set that you've submitted in recent days that has
> > caused build breakages.  Something is wrong with your current
> > development practices.  Are you able to identify and rectify these
> > issue(s) before a lose trust in your submissions?
> >
> 
> Yes, I identified the problem and the config was silently getting
> disabled and hiding all the errors/warning. Driver also was tested on
> OpenWrt build system where the option WERROR wasn't enabled as I was
> devloping other stuff so this added on top of it of not noticing stuff.
> 
> I promise this won't ever happen again. Also I sent v2 for this hoping
> things can get reverted and the correct series can be applied. If not I
> can quickly send a followup that fix this. I verified with the repro
> that the warning/error gets solved. (it's just channging the int to u8)

No need to follow up.

I've applied the new set and sent for pre-testing.

Once passed, I'll push so it'll end up in -next again.

-- 
Lee Jones [李琼斯]