linux-kernel - Re: [PATCH 01/17] syscalls: add generic scripts/syscall.tbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARpWB6Pqa80KDmpdJ_Rf5FZc71_bX9eSy3fFVCAyg8CAg@mail.gmail.com>
Date: Fri, 12 Jul 2024 17:43:57 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: linux-arch@...r.kernel.org, Arnd Bergmann <arnd@...db.de>, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, Vineet Gupta <vgupta@...nel.org>, 
	Russell King <linux@...linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, Guo Ren <guoren@...nel.org>, Brian Cain <bcain@...cinc.com>, 
	Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>, 
	Dinh Nguyen <dinguyen@...nel.org>, Jonas Bonn <jonas@...thpole.se>, 
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, Stafford Horne <shorne@...il.com>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Rich Felker <dalias@...c.org>, 
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, "David S. Miller" <davem@...emloft.net>, 
	Andreas Larsson <andreas@...sler.com>, Christian Brauner <brauner@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-snps-arc@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org, 
	linux-hexagon@...r.kernel.org, loongarch@...ts.linux.dev, 
	linux-openrisc@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 01/17] syscalls: add generic scripts/syscall.tbl

On Thu, Jul 4, 2024 at 11:36 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> The asm-generic/unistd.h header still follows the old style of defining
> system call numbers and the table. Most architectures got the new
> syscall.tbl format as part of the y2038 conversion back in 2018, but
> the newer architectures that share a single table never did.
>
> I did a semi-automated conversion of the asm-generic/unistd.h contents
> into a syscall.tbl format, using the ABI field to take care of all
> the relevant differences that are encoded using #ifdef checks in the
> existing header.
>
> Conversion of the architectures is done one at a time in order to
> be able to review or revert them as needed.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---



> +65     common  readv                           sys_readv                       sys_readv
> +66     common  writev                          sys_writev                      sys_writev


Nit.


I know this is already written in this way
in include/uapi/asm-generic/unistd.h, but
the native and compat have the same function name.


Can we simplify it like this?

65     common  readv                           sys_readv
66     common  writev                          sys_writev






--
Best Regards
Masahiro Yamada