linux-kernel - Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4962ea0-3f03-43b5-b773-68abe1d73cc9@perex.cz>
Date: Fri, 12 Jul 2024 11:20:05 +0200
From: Jaroslav Kysela <perex@...ex.cz>
To: Takashi Iwai <tiwai@...e.de>, Mark Brown <broonie@...nel.org>
Cc: Takashi Iwai <tiwai@...e.com>, Shuah Khan <shuah@...nel.org>,
 linux-sound@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test
 names

On 12. 07. 24 10:21, Takashi Iwai wrote:
> On Thu, 11 Jul 2024 18:19:25 +0200,
> Mark Brown wrote:
>>
>> On Thu, Jul 11, 2024 at 06:08:38PM +0200, Jaroslav Kysela wrote:
>>> On 11. 07. 24 16:33, Mark Brown wrote:
>>
>>>> Address this by replacing our use of card numbers with card names which are
>>>> more likely to be stable across runs. We use the long name since in the
>>
>>> I think that a combination of card number and card ID may be sufficient (and
>>> a compromise). It's shorter and user-friendly. Additionally, a table may be
>>> printed at the beginning of report with card number, card ID and long card
>>> name for further processing and identification.
>>
>> These don't help, the problem is that anything which includes the card
>> number in the test name result is going to result in unstable test names
>> depending on race conditions at boot.  There are automated systems that
>> parse kselftest output generically, I'm not sure there's a great deal of
>> enthusiasm for writing a custom parser for the ALSA selftests
>> specifically.
> 
> OTOH, longname can be really ugly to read, and it can vary because it
> often embeds address or irq numbers in the string.
> 
> If a general name is the goal, how about using shortname instead?
> 
> Or use id field, as Jaroslav suggested, but without the card number
> suffix; then it's unique among multiple cards.

I prefer this (use only ID field). This string can be also set in the user 
space using sysfs/udev, so the administrator may change it if the default is 
not ideal.

					Jaroslav

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.