linux-kernel - Re: [PATCH v2] dt-bindings: incomplete-devices: document devices without bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73038a80-ce58-4967-a258-d6befe23c777@linaro.org>
Date: Fri, 12 Jul 2024 11:41:03 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Marek Vasut <marex@...x.de>,
 Jonathan Cameron <jic23@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: Re: [PATCH v2] dt-bindings: incomplete-devices: document devices
 without bindings

On 11/07/2024 15:01, Rob Herring wrote:
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - description:
>> +          Rejected compatibles in Devicetree, but used in ACPI-based devices
>> +          with non-updatable firmware/ACPI tables (via ACPI PRP0001)
>> +        enum:
>> +          - broadcom,bcm5241
>> +          - ltr,ltrf216a
>> +
>> +      - description: Incorrect compatibles used on Macintosh devices
> 
> They were correct at the time. Rules/standards evolve though. I would
> just say 'Legacy" rather than "Incorrect".

ack

> 
>> +        enum:
>> +          - adm1030
>> +          - bmac+
>> +          - heathrow-media-bay
>> +          - keylargo-media-bay
>> +          - lm87cimt
>> +          - MAC,adm1030
>> +          - MAC,ds1775
>> +          - max6690
>> +          - ohare-media-bay
>> +          - ohare-swim3
>> +          - smu-sat
>> +          - swim3
>> +
>> +      - description: Incorrect compatibles used on other PowerPC devices
>> +        enum:
>> +          - 1682m-rng
>> +          - IBM,lhca
>> +          - IBM,lhea
>> +          - IBM,lhea-ethernet
> 
>> +          - mpc5200b-fec-phy
>> +          - mpc5200-serial
>> +          - mpc5200-sram
> 
> Tell Grant he needs to document these. ;) JK
> 
>> +          - ohci-bigendian
>> +          - ohci-le
>> +          - ohci-littledian
> 
> Given the typo, I think we can just drop this one from the driver.

Sure, I'll send a patch. It could affect some ancient user, though...
Although I really wonder if any of these PowerPC boxes are still alive.

> 
>> +
>> +      - description: Incorrect compatibles used on SPARC devices
>> +        enum:
>> +          - bq4802
>> +          - ds1287
>> +          - isa-m5819p
>> +          - isa-m5823p
>> +          - m5819
>> +          - sab82532
>> +          - SUNW,bbc-beep
>> +          - SUNW,bbc-i2c
>> +          - SUNW,CS4231
>> +          - SUNW,ebus-pic16f747-env
>> +          - SUNW,kt-cwq
>> +          - SUNW,kt-mau
>> +          - SUNW,n2-cwq
>> +          - SUNW,n2-mau
>> +          - SUNW,niusl
>> +          - SUNW,smbus-beep
>> +          - SUNW,sun4v-console
>> +          - SUNW,sun4v-pci
>> +          - SUNW,vf-cwq
>> +          - SUNW,vf-mau
>> +
>> +      - description: Incomplete and incorrect compatibles for unknown devices
>> +        enum:
>> +          - electra-cf
>> +          - i2cpcf,8584
>> +          - virtio,uml
>> +
>> +      - description: Linux kernel unit tests and sample code
>> +        enum:
>> +          - audio-graph-card2-custom-sample
>> +          - compat1
>> +          - compat2
>> +          - compat3
>> +          - linux,spi-loopback-test
>> +          - mailbox-test
>> +          - regulator-virtual-consumer
>> +          - unittest-gpio
>> +          - unittest-pci
> 
> We recently added "test" as a vendor prefix and don't complain if
> "test,.*" compatible is not documented. It's on my todo to change
> these. So I'd drop the unittest ones.

Ack

Best regards,
Krzysztof