linux-kernel - Re: [PATCH V2 3/5] Add aw9610x series related interfaces to the aw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240712095046.2396720-1-wangshuaijie@awinic.com>
Date: Fri, 12 Jul 2024 09:50:46 +0000
From: wangshuaijie@...nic.com
To: krzk@...nel.org
Cc: conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dmitry.torokhov@...il.com,
	jeff@...undy.com,
	kangjiajun@...nic.com,
	krzk+dt@...nel.org,
	linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	liweilei@...nic.com,
	robh@...nel.org,
	wangshuaijie@...nic.com
Subject: Re: [PATCH V2 3/5] Add aw9610x series related interfaces to the aw_sar driver

Hi Krzysztof,

On Wed, 5 Jun 2024 12:22:16, krzk@...nel.org wrote:
>On 05/06/2024 11:11, wangshuaijie@...nic.com wrote:
>> From: shuaijie wang <wangshuaijie@...nic.com>
>> 
>
>No commit msg, no proper subject prefix.
>

The patch for v3 will fix these issues.

>> Signed-off-by: shuaijie wang <wangshuaijie@...nic.com>
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>> | Reported-by: Dan Carpenter <error27@...il.com>
>
>Drop all these, this is some bogus tags. Tag never starts with pipe, btw.
>

The patch for v3 will fix these issues.

>> ---
>>  drivers/input/misc/aw_sar/aw9610x/aw9610x.c | 884 ++++++++++++++++++++
>>  drivers/input/misc/aw_sar/aw9610x/aw9610x.h | 327 ++++++++
>>  2 files changed, 1211 insertions(+)
>>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.c
>>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.h
>
>...
>
>> +struct aw_reg_data {
>> +	unsigned char rw;
>> +	unsigned short reg;
>> +};
>> +/********************************************
>> + * Register Access
>> + *******************************************/
>> +#define REG_NONE_ACCESS					(0)
>> +#define REG_RD_ACCESS					(1 << 0)
>> +#define REG_WR_ACCESS					(1 << 1)
>> +
>> +static const struct aw_reg_data g_aw9610x_reg_access[] = {
>
>Ehh... so we are at basics of C. Data structures do not go to headers.
>

The patch for v3 will fix these issues.

>
>Best regards,
>Krzysztof

Kind regards,
Wang Shuaijie