linux-kernel - Re: [PATCH v2] drivers/clocksource/qcom: Add missing iounmap() on errors in msm_dt_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512601f7-0299-487b-ba7d-7941cf1f0151@linaro.org>
Date: Fri, 12 Jul 2024 11:54:44 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Ankit Agrawal <agrawal.ag.ankit@...il.com>,
 Bjorn Andersson <andersson@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers/clocksource/qcom: Add missing iounmap() on
 errors in msm_dt_timer_init() function.

On 12.07.2024 11:51 AM, Konrad Dybcio wrote:
> On 12.07.2024 10:27 AM, Ankit Agrawal wrote:
>> Add the missing iounmap() when clock frequency fails to get read by the
>> of_property_read_u32() call, or if the call to msm_timer_init() fails.
>>
>> Signed-off-by: Ankit Agrawal <agrawal.ag.ankit@...il.com>
>> ---
> 
> For your future submissions: run:
> 
> /scripts/checkpatch.pl -g $(git describe --abbrev=0)..
> 
> to run some static checks, such as "title is rather long"
> 
> 
> ..but I don't mind!
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Also:

Fixes: 6e3321631ac2 ("ARM: msm: Add DT support to msm_timer")

Konrad