linux-kernel - Re: [PATCH v3 1/2] i2c: smbus: remove i801 assumptions from SPD probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97cf818b-f72c-4461-afec-307ac98d2bf9@gmail.com>
Date: Fri, 12 Jul 2024 12:21:07 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 Andi Shyti <andi.shyti@...nel.org>, Jean Delvare <jdelvare@...e.com>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
 Guenter Roeck <linux@...ck-us.net>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH v3 1/2] i2c: smbus: remove i801 assumptions from SPD
 probing

On 09.07.2024 19:35, Thomas Weißschuh wrote:
> The check and warning are very specific to the SPD usage of the i801
> driver. That was fine as long as i801 was the only caller of
> i2c_register_spd(). Now that piix4 will be added as another user of that
> function, the check and warning are not accurate anymore.
> Instead of introducing a more complicated calling protocol only to print
> a warning, drop the warning.
> Even in cases where not all slots can be probed,
> then at least probe the 8 slots that can be.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>  drivers/i2c/i2c-smbus.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 

Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>