linux-kernel - Re: [PATCH net-next v2] net: ti: icssg-prueth: Split out common object into module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0a8501f-a6e8-412e-bc0f-33e8585790e3@ti.com>
Date: Fri, 12 Jul 2024 17:38:34 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Thorsten Leemhuis <linux@...mhuis.info>, Andrew Lunn <andrew@...n.ch>
CC: Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Diogo Ivo
	<diogo.ivo@...mens.com>, Roger Quadros <rogerq@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet
	<edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <srk@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v2] net: ti: icssg-prueth: Split out common
 object into module



On 12/07/24 5:10 pm, MD Danish Anwar wrote:
> 
> 
> On 12/07/24 4:42 pm, Thorsten Leemhuis wrote:
>> On 26.06.24 09:19, Thorsten Leemhuis wrote:
>>> On 06.06.24 17:54, Andrew Lunn wrote:
>>>>> +EXPORT_SYMBOL_GPL(icssg_class_set_mac_addr);
>>>>> +EXPORT_SYMBOL_GPL(icssg_class_disable);
>>>>> +EXPORT_SYMBOL_GPL(icssg_class_default);
>>>>> +EXPORT_SYMBOL_GPL(icssg_class_promiscuous_sr1);
>>>> [...]
>>>> Please could you clean up the namespace a little. icssg_ and prueth_
>>>> are O.K, but we also have arc/emac_rockchip.c, allwinner/sun4i-emac.c,
>>>> ibm/emac/, and qualcomm/emac/ using the emac_ prefix.
>>>
>>> Just wondering (not as a regression tracker, just as someone that ran
>>> into this and carries the patch in his tree to avoid a build error for
>>> next):
>>>
>>> What happened to this fix? After above feedback nearly 20 days ago
>>> nothing happened afaics. Did this fall through the cracks? Or was some
>>> other solution found and I just missed this (and thus can drop the fix
>>> from my tree)?
>>
>> That inquiry lead to a review from Roger (thx!) more than two weeks ago,
>> but that was all afaics. Makes me wonder if this regression will hit
>> mainline soon, as the merge window might open on Monday already.
>>
>> Ciao, Thorsten
> 
> 
> Andrew L has given comment to clean up the API names. I will rename the
> APIs being exported from emac_ prefix to icssg_ prefix and re-spin this.
> 

Posted v3
https://lore.kernel.org/all/20240712120636.814564-1-danishanwar@ti.com/

-- 
Thanks and Regards,
Danish