linux-kernel - Re: [PATCH 1/1] iommufd: Fix error pointer checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240712125228.GZ14050@ziepe.ca>
Date: Fri, 12 Jul 2024 09:52:28 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Lu Baolu <baolu.lu@...ux.intel.com>
Cc: Kevin Tian <kevin.tian@...el.com>,
	Dan Carpenter <dan.carpenter@...aro.org>, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] iommufd: Fix error pointer checking

On Fri, Jul 12, 2024 at 10:58:19AM +0800, Lu Baolu wrote:
> Smatch static checker reported below warning:
> 
>     drivers/iommu/iommufd/fault.c:131 iommufd_device_get_attach_handle()
>     warn: 'handle' is an error pointer or valid
> 
> Fix it by checking 'handle' with IS_ERR().
> 
> Fixes: b7d8833677ba ("iommufd: Fault-capable hwpt attach/detach/replace")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/linux-iommu/8bb4f37a-4514-4dea-aabb-7380be303895@stanley.mountain/
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> ---
>  drivers/iommu/iommufd/fault.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied

Thanks,
Jason