linux-kernel - Re: next: arm64: defconfig: gcc-8: drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b833c93e-ae8f-449f-b7bd-8d315aa52703@suswa.mountain>
Date: Fri, 12 Jul 2024 08:58:08 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>,
	open list <linux-kernel@...r.kernel.org>,
	lkft-triage@...ts.linaro.org, Arnd Bergmann <arnd@...db.de>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Luiz Augusto von Dentz <luiz.von.dentz@...el.com>
Subject: Re: next: arm64: defconfig: gcc-8:
 drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound
 statement

On Fri, Jul 12, 2024 at 03:34:19AM -0500, Bartosz Golaszewski wrote:
> On Thu, 11 Jul 2024 16:34:35 +0200, Naresh Kamboju
> <naresh.kamboju@...aro.org> said:
> > The arm64 defconfig gcc-8 build failed [1] due to these warnings / errors on the
> > Linux next-20230711 tag. But the gcc-13 builds pass.
> >
> > LKFT is testing older toolchain support till gcc-8.
> >
> > The following recent changes cause this failure.
> > a887c8dede8e1 Bluetooth: hci_qca: schedule a devm action for disabling the clock
> >
> > Build errors with gcc-8:
> > -----------
> > drivers/bluetooth/hci_qca.c: In function 'qca_serdev_remove':
> > drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound statement
> >   default:
> >   ^~~~~~~
> > make[5]: *** [scripts/Makefile.build:244: drivers/bluetooth/hci_qca.o]
> > Error 1a887c8dede8e1 Bluetooth: hci_qca: schedule a devm action for
> > disabling the clock
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> >
> > Build data:
> > ------
> >   * Build name: gcc-8-defconfig
> >   * git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
> >   * git_sha: f477dd6eede3ecedc8963478571d99ec3bf3f762
> >   * git_short_log: f477dd6eede3 ("Add linux-next specific files for 20240711")
> >   * Config: defconfig
> >   * arch: arm64
> >   * toolchain: gcc-8
> >
> > Steps to reproduce:
> > -------
> > # tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8
> > --kconfig defconfig
> >
> > Build log links,
> > ---------------
> >  [1] https://storage.tuxsuite.com/public/linaro/lkft/builds/2j5nr85T4iLl99RjcJ9oy9O3eo2/
> >
> > --
> > Linaro LKFT
> > https://lkft.linaro.org
> >
> >
> 
> The actual code looks like this now:
> 
> 	case QCA_WCN7850:
> 		if (power->vregs_on)
> 			qca_power_shutdown(&qcadev->serdev_hu);
> 		break;
> 	default:
> 
> What can be done to silence this warning? Or should we just ignore it because
> it's gcc 8?

Just add a break statement.

	default:
+		break;
	}

regards,
dan carpenter