linux-kernel - Re: [PATCH] agp: uninorth: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a01ee4b-73af-3818-ecd5-cce5e270eeb6@quicinc.com>
Date: Fri, 12 Jul 2024 08:22:00 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Jeff Johnson <quic_jjohnson@...cinc.com>,
        David Airlie
	<airlied@...hat.com>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] agp: uninorth: add missing MODULE_DESCRIPTION() macro

On 7/12/2024 1:31 AM, Greg Kroah-Hartman wrote:
> On Thu, Jul 11, 2024 at 01:27:23PM -0600, Jeffrey Hugo wrote:
>> On 7/11/2024 12:19 PM, Jeff Johnson wrote:
>>> On 6/28/24 20:14, Jeff Johnson wrote:
>>>> On 6/15/2024 2:01 PM, Jeff Johnson wrote:
>>>>> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
>>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>>>> drivers/char/agp/uninorth-agp.o
>>>>>
>>>>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>>>>
>>>>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>>>>> ---
>>>>>    drivers/char/agp/uninorth-agp.c | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/char/agp/uninorth-agp.c
>>>>> b/drivers/char/agp/uninorth-agp.c
>>>>> index 84411b13c49f..b8d7115b8c9e 100644
>>>>> --- a/drivers/char/agp/uninorth-agp.c
>>>>> +++ b/drivers/char/agp/uninorth-agp.c
>>>>> @@ -726,4 +726,5 @@ MODULE_PARM_DESC(aperture,
>>>>>             "\t\tDefault: " DEFAULT_APERTURE_STRING "M");
>>>>>    MODULE_AUTHOR("Ben Herrenschmidt & Paul Mackerras");
>>>>> +MODULE_DESCRIPTION("Apple UniNorth & U3 AGP support");
>>>>>    MODULE_LICENSE("GPL");
>>>>>
>>>>> ---
>>>>> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
>>>>> change-id: 20240615-md-powerpc-drivers-char-agp-db644db58c24
>>>>
>>>> Following up to see if anything else is needed from me. Hoping to
>>>> see this in
>>>> linux-next so I can remove it from my tracking spreadsheet :)
>>>
>>> I still don't see this in linux-next.
>>> Adding Greg KH since he's picked up many of these fixes.
>>> Hope to have all of these warnings fixed tree-wide in 6.11.
>>
>> Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
>>
>> Dave, this seems like a trivial fix that is stuck, but normally routed
>> through DRM.  I hope I'm not over stepping, but I think I'll drop this in
>> drm-misc-next on the 19th if there isn't any other activity.
> 
> I can take it now, otherwise you will miss the 6.11-rc1 merge window.

Works for me.  Thanks Greg!

-Jeff