linux-kernel - Re: [PATCH V3 2/2] Add support for Awinic proximity sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc509d3a-7e25-49f3-94a2-5a6bb36f062d@web.de>
Date: Fri, 12 Jul 2024 16:33:04 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: shuaijie wang <wangshuaijie@...nic.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 Jonathan Cameron <jic23@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh@...nel.org>, Waqar Hameed <waqar.hameed@...s.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kangjiajun@...nic.com,
 Nick Li <liweilei@...nic.com>
Subject: Re: [PATCH V3 2/2] Add support for Awinic proximity sensor

Please add a subsystem specification to the message subject.


…
> +++ b/drivers/iio/proximity/aw_sar.c
> @@ -0,0 +1,1850 @@
…
> +static ssize_t
> +update_reg_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
> +{
…
> +	if (flag == AW_TRUE) {
> +		mutex_lock(&aw_sar_lock);
> +		aw_sar_soft_reset(p_sar);
> +		aw_sar_update_reg_set_func(p_sar);
> +		mutex_unlock(&aw_sar_lock);
> +	}
> +
> +	return count;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&aw_sar_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/mutex.h#L196

Regards,
Markus