linux-kernel - Re: [PATCH 2/5] dt-bindings: thermal: qcom: Add MBG thermal monitor bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172079487284.777333.16103955331263207845.robh@kernel.org>
Date: Fri, 12 Jul 2024 08:34:32 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
Cc: Jishnu Prakash <quic_jprakash@...cinc.com>, 
 Amit Kucheria <amitk@...nel.org>, linux-iio@...r.kernel.org, 
 Lukasz Luba <lukasz.luba@....com>, Bjorn Andersson <andersson@...nel.org>, 
 Taniya Das <quic_tdas@...cinc.com>, 
 Thara Gopinath <thara.gopinath@...il.com>, Zhang Rui <rui.zhang@...el.com>, 
 linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@...aro.org>, 
 Kamal Wadhwa <quic_kamalw@...cinc.com>, devicetree@...r.kernel.org, 
 Jagadeesh Kona <quic_jkona@...cinc.com>, 
 Jonathan Cameron <jic23@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Imran Shaik <quic_imrashai@...cinc.com>, 
 Lars-Peter Clausen <lars@...afoo.de>, 
 Daniel Lezcano <daniel.lezcano@...aro.org>, linux-arm-msm@...r.kernel.org, 
 "Rafael J. Wysocki" <rafael@...nel.org>, linux-pm@...r.kernel.org, 
 Ajit Pandey <quic_ajipan@...cinc.com>
Subject: Re: [PATCH 2/5] dt-bindings: thermal: qcom: Add MBG thermal
 monitor bindings

On Fri, 12 Jul 2024 18:13:29 +0530, Satya Priya Kakitapalli wrote:
> Add bindings support for the MBG Temp alarm peripheral found on
> pm8775 pmics.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
> ---
>  .../bindings/thermal/qcom-spmi-mbg-tm.yaml         | 63 ++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
In file included from Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.example.dts:25:
./scripts/dtc/include-prefixes/dt-bindings/iio/adc/qcom,spmi-adc5-gen3-pm8775.h:9:10: fatal error: dt-bindings/iio/adc/qcom,spmi-vadc.h: No such file or directory
    9 | #include <dt-bindings/iio/adc/qcom,spmi-vadc.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240712-mbg-tm-support-v1-2-7d78bec920ca@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.