linux-kernel - Re: linux-next: build failure after merge of the cgroup tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734oe1xak.fsf@trenco.lwn.net>
Date: Fri, 12 Jul 2024 08:48:19 -0600
From: Jonathan Corbet <corbet@....net>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Tejun Heo <tj@...nel.org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the cgroup tree

Stephen Rothwell <sfr@...b.auug.org.au> writes:

> Hi all,
>
> On Fri, 12 Jul 2024 16:43:54 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>>
>> After merging the cgroup tree, today's linux-next build (htmldocs)
>> failed like this:
>> 
>> Sphinx parallel build error:
>> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfd in position 558: invalid start byte
>> 
>> Caused by commit
>> 
>>   704f684e15ad ("cgroup: Add Michal Koutný as a maintainer")
>> 
>> I tracked this down using
>> 
>>   git diff stable.. | cat -v | grep -F 'M-}'
>> 
>> and finding the commit that added the line that was output.
>> I tested it by building with the commit temporarily reverted.  I have
>> left that commit in today's linux-next.
>> 
>> Clearly (I think) there is nothing wrong with the commit, but the Sphinx
>> utf-8 decoder also clearly does not think it is valid UTF-8 :-(
>
> Actually my character map app says that it should be the two bytes 0xC3
> 0xBD in UTF-8 (it is 0x00FD in UTF-16).

As you observed, the patch is encoded in ISO-8859, not UTF8; that
doesn't fit well in a file that uses UTF8.  One could argue that Sphinx
should be a bit more robust, but satisfactory results will not be had
regardless.

An encoding check might be a useful thing to have in checkpatch.pl,
methinks.

jon