linux-kernel - Re: [PATCH] md/raid1: set max_sectors during early return from choose_slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW6sjMr_Eoqc4J7NjfdJDwLtTSEqQOeC_+EyiSVKYq8gvw@mail.gmail.com>
Date: Fri, 12 Jul 2024 23:11:01 +0800
From: Song Liu <song@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: Mateusz Jończyk <mat.jonczyk@...pl>, 
	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org, Paul Luse <paul.e.luse@...ux.intel.com>, 
	Xiao Ni <xni@...hat.com>, Mariusz Tkaczyk <mariusz.tkaczyk@...ux.intel.com>, 
	"yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] md/raid1: set max_sectors during early return from choose_slow_rdev()

On Fri, Jul 12, 2024 at 9:17 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
[...]
> >
> > After investigation, it turned out that choose_slow_rdev() does not set
> > the value of max_sectors in some cases and because of it,
> > raid1_read_request calls bio_split with sectors == 0.
> >
> > Fix it by filling in this variable.
> >
> > This bug was introduced in
> > commit dfa8ecd167c1 ("md/raid1: factor out choose_slow_rdev() from read_balance()")
> > but apparently hidden until
> > commit 0091c5a269ec ("md/raid1: factor out helpers to choose the best rdev from read_balance()")
> > shortly thereafter.
> >
> > Cc: stable@...r.kernel.org # 6.9.x+
> > Signed-off-by: Mateusz Jończyk <mat.jonczyk@...pl>
> > Fixes: dfa8ecd167c1 ("md/raid1: factor out choose_slow_rdev() from read_balance()")
> > Cc: Song Liu <song@...nel.org>
> > Cc: Yu Kuai <yukuai3@...wei.com>
> > Cc: Paul Luse <paul.e.luse@...ux.intel.com>
> > Cc: Xiao Ni <xni@...hat.com>
> > Cc: Mariusz Tkaczyk <mariusz.tkaczyk@...ux.intel.com>
> > Link: https://lore.kernel.org/linux-raid/20240706143038.7253-1-mat.jonczyk@o2.pl/
> >
> > --
>
> Thanks for the patch!
>
> Reviewed-by: Yu Kuai <yukuai3@...wei.com>

Applied to md-6.11. Thanks!

Song