linux-kernel - Re: [PATCH -next] blk-cgroup: move congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpFlsrNMMUMnT_Lq@slm.duckdns.org>
Date: Fri, 12 Jul 2024 07:19:46 -1000
From: Tejun Heo <tj@...nel.org>
To: Xiu Jianfeng <xiujianfeng@...wei.com>
Cc: josef@...icpanda.com, axboe@...nel.dk, lizefan.x@...edance.com,
	hannes@...xchg.org, cgroups@...r.kernel.org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] blk-cgroup: move congestion_count to struct blkcg

Hello,

On Fri, Jul 12, 2024 at 08:51:41AM +0000, Xiu Jianfeng wrote:
> The congestion_count was introduced by commit d09d8df3a294 ("blkcg:
> add generic throttling mechanism"), but since it is closely related
> to the blkio subsys, it is not appropriate to put it in the struct
> cgroup, so move it to struct blkcg.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
> ---
> only compiling tested

blkcg is per cgroup and blkg is per cgroup-device pair, so the change isn't
just moving the field but updating what it means and how it works. The
change needs a lot more thinking, justification and testing.

Thanks.

-- 
tejun