linux-kernel - Re: [PATCH V3 2/2] Add support for Awinic proximity sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202407131316.CrET2D2p-lkp@intel.com>
Date: Sat, 13 Jul 2024 14:15:19 +0800
From: kernel test robot <lkp@...el.com>
To: wangshuaijie@...nic.com, jic23@...nel.org, lars@...afoo.de,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	waqar.hameed@...s.com, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, wangshuaijie@...nic.com,
	liweilei@...nic.com, kangjiajun@...nic.com
Subject: Re: [PATCH V3 2/2] Add support for Awinic proximity sensor

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 43db1e03c086ed20cc75808d3f45e780ec4ca26e]

url:    https://github.com/intel-lab-lkp/linux/commits/wangshuaijie-awinic-com/dt-bindings-iio-Add-YAML-to-Awinic-proximity-sensor/20240712-194024
base:   43db1e03c086ed20cc75808d3f45e780ec4ca26e
patch link:    https://lore.kernel.org/r/20240712113200.2468249-3-wangshuaijie%40awinic.com
patch subject: [PATCH V3 2/2] Add support for Awinic proximity sensor
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240713/202407131316.CrET2D2p-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240713/202407131316.CrET2D2p-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407131316.CrET2D2p-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/iio/proximity/aw9610x.c: In function 'aw9610x_datablock_load':
>> drivers/iio/proximity/aw9610x.c:665:1: warning: the frame size of 1356 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     665 | }
         | ^


vim +665 drivers/iio/proximity/aw9610x.c

   634	
   635	static void aw9610x_datablock_load(struct aw_sar *p_sar, const char *buf)
   636	{
   637		struct aw9610x *aw9610x = p_sar->priv_data;
   638		unsigned char addr_bytes = aw9610x->aw_i2c_package.addr_bytes;
   639		unsigned char data_bytes = aw9610x->aw_i2c_package.data_bytes;
   640		unsigned char reg_num = aw9610x->aw_i2c_package.reg_num;
   641		unsigned char reg_data[220] = { 0 };
   642		unsigned int databuf[220] = { 0 };
   643		unsigned char temp_buf[2] = { 0 };
   644		unsigned int i;
   645	
   646		for (i = 0; i < data_bytes * reg_num; i++) {
   647			if (reg_num < attr_buf[1]) {
   648				temp_buf[0] = buf[attr_buf[0] + (addr_bytes + i) * 5];
   649				temp_buf[1] =
   650					buf[attr_buf[0] + (addr_bytes + i) * 5 + 1];
   651			} else if (reg_num >= attr_buf[1] && reg_num < attr_buf[3]) {
   652				temp_buf[0] = buf[attr_buf[2] + (addr_bytes + i) * 5];
   653				temp_buf[1] =
   654					buf[attr_buf[2] + (addr_bytes + i) * 5 + 1];
   655			} else if (reg_num >= attr_buf[3] && reg_num < attr_buf[5]) {
   656				temp_buf[0] = buf[attr_buf[4] + (addr_bytes + i) * 5];
   657				temp_buf[1] =
   658					buf[attr_buf[4] + (addr_bytes + i) * 5 + 1];
   659			}
   660			sscanf(temp_buf, "%02x", &databuf[i]);
   661			reg_data[i] = (unsigned char)databuf[i];
   662		}
   663		aw9610x->aw_i2c_package.p_reg_data = reg_data;
   664		aw9610x_awrw_write_seq(p_sar);
 > 665	}
   666	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki