linux-kernel - Re: [RFC PATCH 4/4] LoongArch: Remove -fno-jump-tables for objtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae3ff9787e9d3f41b71e8e4168610a01d5304371.camel@xry111.site>
Date: Sat, 13 Jul 2024 17:10:20 +0800
From: Xi Ruoyao <xry111@...111.site>
To: Tiezhu Yang <yangtiezhu@...ngson.cn>, Josh Poimboeuf
 <jpoimboe@...nel.org>,  Peter Zijlstra <peterz@...radead.org>, Huacai Chen
 <chenhuacai@...nel.org>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 4/4] LoongArch: Remove -fno-jump-tables for objtool

On Fri, 2024-07-12 at 17:49 +0800, Xi Ruoyao wrote:
> On Fri, 2024-07-12 at 17:15 +0800, Tiezhu Yang wrote:
> > -ifdef CONFIG_OBJTOOL
> > -KBUILD_CFLAGS			+= -fno-jump-tables
> > -endif
> > +KBUILD_AFLAGS			+= $(call cc-option,-mannotate-tablejump) $(call cc-option,-Wa$(comma)-mannotate-tablejump)
> > +KBUILD_CFLAGS			+= $(call cc-option,-mannotate-tablejump) $(call cc-option,-Wa$(comma)-mannotate-tablejump)
> 
> KBUILD_AFLAGS isn't needed, and $(call cc-option,-Wa$(comma)-mannotate-
> tablejump) will always expand to nothing because the assembler does not
> have -mannotate-tablejump.
> 
> The assembler never creates a jump table itself.

BTW have you discussed with Lulu about the -mannotate-tablejump patch? 
I guess maybe an intra-Loongson discussion would be helpful.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University