linux-kernel - Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240713131510.2c13f2bf@jic23-huawei>
Date: Sat, 13 Jul 2024 13:15:10 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: wangshuaijie@...nic.com, lars@...afoo.de, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, waqar.hameed@...s.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, liweilei@...nic.com, kangjiajun@...nic.com
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity
 sensor


> 
> > +    description:
> > +      Choose if you want to use a regulator to power the chip. Then the
> > +      vccX-supply has to be set.
> > +
> > +  vcc0-supply:
> > +    description:
> > +      Optional regulator for chip, 1.7V-3.6V.
> > +      If two awinic sar chips are used, the first regulator
> > +      should set the ID to vcc0-supply and the second regulator
> > +      should set the ID to vcc1-supply.
> > +
> > +  awinic,channel-use-mask:  
> 
> Aren't there existing IIO properties like this?
> 
I'm not sure what this is. If it's about the chip support then the compatible
is enough.  If is is about what is wired, then use child nodes per channel
to describe what is connected up.

See adc.yaml for an example - similar can be used for other device types.

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      The mask of channels used.
> > +      Configure according to the specific chip channel used.
> > +      Bit[31:0] Each bit represents a channel.
> > +      If the customer uses ch0 and ch2, then channel_use_mask=<0x05>
> > +      For a 3-channel chip, the maximum value is 0x07;
> > +      For a 5-channel chip, the maximum value is 0x1F;
> > +      For a 8-channel chip, the maximum value is 0xFF;
> > +
> > +  awinic,monitor-esd:
> > +    type: boolean
> > +    description:
> > +      Choose if you want to monitor ESD.