[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c7iwx6erdqv7uahd47ymlwcid67wbfizkblngv7r3dx7i2i735@ujams5zx6b5b>
Date: Sat, 13 Jul 2024 14:37:34 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Hironori KIKUCHI <kikuchan98@...il.com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
Aleksandr Shubin <privatesub2@...il.com>, Cheo Fusi <fusibrandon13@...il.com>, linux-pwm@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 2/5] pwm: sun20i: Add support for Allwinner H616 PWM
Hello,
On Fri, May 31, 2024 at 11:11:34PM +0900, Hironori KIKUCHI wrote:
> @@ -20,8 +20,17 @@
> #include <linux/pwm.h>
> #include <linux/reset.h>
>
> +#define SUN20I_PWM_REG_OFFSET_PER_D1 (0x0080)
> +#define SUN20I_PWM_REG_OFFSET_PCR_D1 (0x0100 + 0x0000)
> +#define SUN20I_PWM_REG_OFFSET_PPR_D1 (0x0100 + 0x0004)
> +#define SUN20I_PWM_REG_OFFSET_PER_H616 (0x0040)
> +#define SUN20I_PWM_REG_OFFSET_PCR_H616 (0x0060 + 0x0000)
> +#define SUN20I_PWM_REG_OFFSET_PPR_H616 (0x0060 + 0x0004)
Instead of having a conditional for each register, it would be easier
to do:
#define SUN20I_PWM_CHANBASE_D1 0x80
#define SUN20I_PWM_CHANBASE_H616 0x40
(maybe with a more suitable name) and then do:
#define SUN20I_PWM_PER(sun20i_chip) ((sun20i_chip)->chanbase + 0)
#define SUN20I_PWM_PCR(sun20i_chip) ((sun20i_chip)->chanbase + 0x20)
#define SUN20I_PWM_PPR(sun20i_chip) ((sun20i_chip)->chanbase + 0x24)
I would expect these definitions to appear in the order of register
addresses, that is below SUN20I_PWM_CLK_CFG. This reduces the size of
the private data struct, is easier to understnad to a human (I think)
and I claim this results in more compact code (without having it
verified).
Best regards
Uwe
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists