linux-kernel - Re: [RFC PATCH] drm: panthor: add dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <76D10179-FC78-4563-93CD-0528E3420D45@collabora.com>
Date: Fri, 12 Jul 2024 22:00:26 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Dave Airlie <airlied@...il.com>
Cc: Danilo Krummrich <dakr@...hat.com>,
 Steven Price <steven.price@....com>,
 Wedson Almeida Filho <wedsonaf@...il.com>,
 ojeda@...nel.org,
 lyude@...hat.com,
 robh@...nel.org,
 lina@...hilina.net,
 mcanal@...lia.com,
 rust-for-linux@...r.kernel.org,
 dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

Hi Dave,

> 
> I think I'm on the uapi should remain in C for now, we define uapi
> types with the kernel types and we have downstream tools to scan and
> parse them to deal with alignments and padding (I know FEX relies on
> it), so I think we should be bindgen from uapi headers into rust for
> now. There might be a future where this changes, but that isn't now
> and I definitely don't want to mix C and rust uapi in one driver.
> 
> Dave.

Yeah, once this was mentioned:

> How do we (easily) verify that changes in the Rust code don't break the uAPI by
> due to leading to changes in the generated header files?
> 
> Do we have guarantees that future releases of cbindgen can't break anything?


I realized that there would be issues with my original approach.

> I think I'm on the uapi should remain in C for now

No worries, I will fix this in v2.

— Daniel