linux-kernel - Re: [PATCH v2] rust: firmware: fix invalid rustdoc link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpKUEKHh6gK7SODR@pollux.localdomain>
Date: Sat, 13 Jul 2024 16:49:52 +0200
From: Danilo Krummrich <dakr@...hat.com>
To: gregkh@...uxfoundation.org
Cc: miguel.ojeda.sandonis@...il.com, a.hindborg@...sung.com,
	alex.gaynor@...il.com, aliceryhl@...gle.com, benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com, boqun.feng@...il.com, gary@...yguo.net,
	andrewjballance@...il.com,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	linux-kernel@...r.kernel.org, mcgrof@...nel.org, ojeda@...nel.org,
	russ.weight@...ux.dev, rust-for-linux@...r.kernel.org,
	skhan@...uxfoundation.org, wedsonaf@...il.com
Subject: Re: [PATCH v2] rust: firmware: fix invalid rustdoc link

Hi Greg,

On Mon, Jul 08, 2024 at 07:44:26PM -0500, Andrew Ballance wrote:
> remove an extra quote from the doc comment so that rustdoc
> no longer genertes a link to a nonexistent file.
> 
> Signed-off-by: Andrew Ballance <andrewjballance@...il.com>
> Reviewed-by: Danilo Krummrich <dakr@...hat.com>
> Acked-by: Miguel Ojeda <ojeda@...nel.org>
> Fixes: de6582833db0 ("rust: add firmware abstractions")

Can you please pick this one up?

- Danilo

> ---
> v1 -> v2: updated commit message
> 
>  rust/kernel/firmware.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/firmware.rs b/rust/kernel/firmware.rs
> index 386c8fb44785..763d7cbefab5 100644
> --- a/rust/kernel/firmware.rs
> +++ b/rust/kernel/firmware.rs
> @@ -2,7 +2,7 @@
>  
>  //! Firmware abstraction
>  //!
> -//! C header: [`include/linux/firmware.h`](srctree/include/linux/firmware.h")
> +//! C header: [`include/linux/firmware.h`](srctree/include/linux/firmware.h)
>  
>  use crate::{bindings, device::Device, error::Error, error::Result, str::CStr};
>  use core::ptr::NonNull;
> -- 
> 2.45.2
>