linux-kernel - Re: [PATCH -next] blk-cgroup: move congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpK63tsWBNMGFR2t@slm.duckdns.org>
Date: Sat, 13 Jul 2024 07:35:26 -1000
From: Tejun Heo <tj@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: Xiu Jianfeng <xiujianfeng@...wei.com>, josef@...icpanda.com,
	axboe@...nel.dk, lizefan.x@...edance.com, hannes@...xchg.org,
	cgroups@...r.kernel.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH -next] blk-cgroup: move congestion_count to struct blkcg

Hello,

On Sat, Jul 13, 2024 at 06:56:57PM +0800, Yu Kuai wrote:
> 在 2024/07/13 1:19, Tejun Heo 写道:
> > Hello,
> > 
> > On Fri, Jul 12, 2024 at 08:51:41AM +0000, Xiu Jianfeng wrote:
> > > The congestion_count was introduced by commit d09d8df3a294 ("blkcg:
> > > add generic throttling mechanism"), but since it is closely related
> > > to the blkio subsys, it is not appropriate to put it in the struct
> > > cgroup, so move it to struct blkcg.
> > > 
> > > Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
> > > ---
> > > only compiling tested
> > 
> > blkcg is per cgroup and blkg is per cgroup-device pair, so the change isn't
> > just moving the field but updating what it means and how it works. The
> > change needs a lot more thinking, justification and testing
> I understand blkcg and blkg, however, maybe I'm being noob, I don't see
> how this patch is related to blkg, the change is that 'congestion_count'
> is moved from cgroup to blkcg. This look quite straightforward to me,
> maybe I'm missing something, can you explain more?

Oh, my apologies. That was me confidently misreading the patch. Sorry about
that. I'll re-read the patch.

Thanks.

-- 
tejun