linux-kernel - [PATCH] nfsd: Use seq_putc() in seq_quote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ab25204c-5a53-42e1-ab3a-c4f704ebc929@web.de>
Date: Sat, 13 Jul 2024 21:16:14 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-nfs@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Chuck Lever <chuck.lever@...cle.com>, Dai Ngo <Dai.Ngo@...cle.com>,
 Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>,
 Olga Kornievskaia <kolga@...app.com>, Tom Talpey <tom@...pey.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] nfsd: Use seq_putc() in seq_quote_mem()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 13 Jul 2024 21:07:09 +0200

Double quotation characters should be put into a sequence
around other data.
Thus use the function “seq_putc” accordingly.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/nfsd/nfs4state.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index a20c2c9d7d45..1d15165a15cf 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2636,9 +2636,9 @@ static struct nfs4_client *get_nfsdfs_clp(struct inode *inode)

 static void seq_quote_mem(struct seq_file *m, char *data, int len)
 {
-	seq_puts(m, "\"");
+	seq_putc(m, '"');
 	seq_escape_mem(m, data, len, ESCAPE_HEX | ESCAPE_NAP | ESCAPE_APPEND, "\"\\");
-	seq_puts(m, "\"");
+	seq_putc(m, '"');
 }

 static const char *cb_state2str(int state)
--
2.45.2